-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: review the pub types/fields(post-split)(1) #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think there should be no #[allow(dead_code)]
anywhere, because it's only needed for non-pub
entries, but if they're not public and they're not used anywhere, why keep them?
halo2_frontend/src/dev.rs
Outdated
@@ -85,26 +85,31 @@ impl Region { | |||
} | |||
|
|||
/// Returns the name of the region. | |||
#[allow(dead_code)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's inconsistent that Region
is not pub but it has pub
methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the mehods in 82ff602
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @ed255, we shouldn't have #[allow(dead_code)]
, these functions should be removed or remain pub
.
The purpose of this PR is to restore function visibility to the state be fore the front/back split right? ( I assume that during the process, the visibility for many function was increased for convenience.)
If this is the case, I suggest we leave thing as pub
when in doubt.
Thanks for the detailed review! @ed255 @davidnevadoc I followed the suggestions - roll back some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Related issues
Changes
(crate)
limit to needed types/fields in every crate#[allow(dead_code)]
for only necessary case, likeDebug
-derived structs(PinnedVerificationKey, ...)